Improve lexer_expect_object_literal_id option handling #2436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
requested changes
Jul 24, 2018
| @@ -379,7 +379,7 @@ parser_parse_class_literal (parser_context_t *context_p, /**< context */ | |||
| lexer_skip_empty_statements (context_p); | |||
| } | |||
|
|
|||
| lexer_expect_object_literal_id (context_p, false); | |||
| lexer_expect_object_literal_id (context_p, LEXER_OBJ_IDENT_CLASS_METHOD | LEXER_OBJ_IDENT_NO_OPTS); | |||
There was a problem hiding this comment.
Good catch, it is unnecessary.
rerobika
force-pushed
the
improve_expect_object_literal_id
branch
from
89e5115 to
2445998
Compare
zherczeg
requested changes
Jul 24, 2018
| { | ||
| lexer_skip_spaces (context_p); | ||
|
|
||
| #ifndef CONFIG_DISABLE_ES2015_CLASS | ||
| int is_class_method = ((context_p->status_flags & PARSER_IS_CLASS) |
There was a problem hiding this comment.
It's no longer needed so it had been removed here.
zherczeg
reviewed
Jul 24, 2018
| @@ -68,7 +68,6 @@ typedef enum | |||
| PARSER_ARROW_PARSE_ARGS = (1u << 19), /**< parse the argument list of an arrow function */ | |||
| #endif /* !CONFIG_DISABLE_ES2015_ARROW_FUNCTION */ | |||
| #ifndef CONFIG_DISABLE_ES2015_CLASS | |||
| PARSER_IS_CLASS = (1u << 20), /**< statements parsed inside class body */ | |||
| PARSER_CLASS_CONSTRUCTOR = (1u << 21), /**< a class constructor is parsed */ | |||
There was a problem hiding this comment.
Thanks, I've forgotten it.
This patch allows to add further options flags to `lexer_expect_object_literal_id` to handle unique behaviors more easily also substitutes `PARSER_IS_CLASS` flag hence it is removed. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
rerobika
force-pushed
the
improve_expect_object_literal_id
branch
from
2445998 to
4d4bec7
Compare
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 29, 2018
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 29, 2018
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 29, 2018
yorkie
pushed a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 30, 2018
Refs: jerryscript-project/jerryscript#2431 Refs: jerryscript-project/jerryscript#2496 Refs: jerryscript-project/jerryscript#2485 Refs: jerryscript-project/jerryscript#2530 Refs: jerryscript-project/jerryscript#2547 Refs: jerryscript-project/jerryscript#2436 Refs: jerryscript-project/jerryscript#2467 Refs: jerryscript-project/jerryscript#2481 Refs: jerryscript-project/jerryscript#2408 Refs: jerryscript-project/jerryscript#2430 Refs: jerryscript-project/jerryscript#2439 Refs: jerryscript-project/jerryscript#2588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows to add further options flags to
lexer_expect_object_literal_idto handle unique behaviors more easilyalso substitutes
PARSER_IS_CLASSflag hence it is removed.JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]